Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render the thumbnails if there are canvas groupings in the first place #4063

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 18, 2024

This incidentally fixes a problem with the first item in the canvas navigation, which seems like it might start to render before we have dimension information and we use the default width instead of the canvas width:

Before:
Screenshot 2024-12-18 at 10 45 37

After/correct:
Screenshot 2024-12-18 at 10 45 58

@cbeer cbeer force-pushed the canvas-groupings-guard branch from b00e56a to 56967b9 Compare December 18, 2024 18:54
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (644b804) to head (816eef8).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4063   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         313      313           
  Lines       14752    14753    +1     
  Branches     2486     2487    +1     
=======================================
+ Hits        13943    13944    +1     
  Misses        804      804           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeer cbeer force-pushed the canvas-groupings-guard branch from 56967b9 to 816eef8 Compare December 18, 2024 19:27
@marlo-longley marlo-longley merged commit d5b1bc9 into master Dec 18, 2024
10 checks passed
@marlo-longley marlo-longley deleted the canvas-groupings-guard branch December 18, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants