Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some test warnings #4064

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Clean up some test warnings #4064

merged 5 commits into from
Dec 18, 2024

Conversation

cbeer
Copy link
Collaborator

@cbeer cbeer commented Dec 18, 2024

vitest does a better job flagging some testing setup issues (or some proptypes mistakes).

@cbeer cbeer changed the title Clean up test warnings from SidebarIndexList Clean up some test warnings Dec 18, 2024
@marlo-longley marlo-longley merged commit 01ebfc1 into master Dec 18, 2024
8 checks passed
@marlo-longley marlo-longley deleted the test-warnings branch December 18, 2024 21:43
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (644b804) to head (d85dadc).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4064      +/-   ##
==========================================
- Coverage   94.51%   94.50%   -0.01%     
==========================================
  Files         313      313              
  Lines       14752    14751       -1     
  Branches     2486     2484       -2     
==========================================
- Hits        13943    13941       -2     
- Misses        804      805       +1     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants