-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wemake
has 80 chars hard limit, not 79
#2241
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 40 40
Lines 3096 3096
Branches 787 787
=======================================
Hits 3069 3069
Misses 15 15
Partials 12 12 |
Lint failure is unrelated:
|
After fixing it, |
@staticdev friendly ping :) |
@timothycrosley looks like this project needs an extra pair of eyes :) My email is in my profile, just in case. |
This comment was marked as spam.
This comment was marked as spam.
It is a dev-dependency and there's no real vulnerability. This is why a job in my CI fails: PyCQA#2241 Link to CVE: https://data.safetycli.com/v/64484/f17 Or you can bump `bandit` to 1.7.8: https://pypi.org/project/bandit/1.7.8/
@sigmavirus24 is there anything I can do to help fixing this? It affects all my projects and lots of my users. There was no reaction from isort team for half a year. I want to escalate this to PyCQA, because I still receive bug reports about this issue in my own projects :( |
@sobolevn PyCQA is a loose aggregation of projects. I provide the administration of the org & teams to help facilitate things for folks, but I don't take over projects or merge things unless asked to help by the owners/maintainers. In other words, I won't provide review on this, approve it, merge it, etc. And I will not arbitrarily add you to the team to maintain this. Even if I did, I cannot add you to the package on PyPI in order to release it (assuming release automation isn't already present on this repository). |
Thanks for the quick feedback! It is totally reasonable. I was not asking for any of these actions from you, just letting you know: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Edit: Opened and closed to retrigger actions.
Thanks @sobolevn LGTM. |
Thank you! |
Proof:
Refs:
wemake
linter #2183wemake
profile inconsistency: 80 vs 79 line length #2182