Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect unit conversion in hydro function in convert.py #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lukasschirren
Copy link

Removed unnecessary factor of 1000/24 from the runoff calculation, as pointed out by user JKALanger. The function now correctly calculates runoff in m3 per hour by directly multiplying the depth (in meters per hour) by the basin area (in square meters).

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

lukasschirren and others added 2 commits January 7, 2025 16:17
Removed unnecessary factor of 1000/24 from the runoff calculation, as pointed out by user JKALanger.
The function now correctly calculates runoff in m3 per hour
by directly multiplying the depth (in meters per hour) by the basin area (in square meters).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant