Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check objective in test routines #1468

Merged
merged 5 commits into from
Jan 16, 2025
Merged

feat: check objective in test routines #1468

merged 5 commits into from
Jan 16, 2025

Conversation

FabianHofmann
Copy link
Contributor

Option to counter-check the objective value against expected value. With this check, we make sure that no strong deviations from the expected objective are introduced. In case the objective varies stronger than the allowed tolerance, but for a good reason (new tech/tech costs), the expected value has to be updated manually.

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • test-objective failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing test-objective (adfe791) with master (bd5e36c).
Branch is 5 commits ahead and 0 commits behind.
Last updated on 2025-01-16 19:42:26 CET.

@FabianHofmann FabianHofmann requested a review from lkstrp December 23, 2024 12:41
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good utility!

config/config.default.yaml Outdated Show resolved Hide resolved
scripts/solve_network.py Show resolved Hide resolved
@lkstrp
Copy link
Member

lkstrp commented Jan 15, 2025

Would this have catched the linopy bug? I guess no since the test configs are to small?

Makefile Show resolved Hide resolved
@FabianHofmann
Copy link
Contributor Author

Would this have catched the linopy bug? I guess no since the test configs are to small?

I think so yes! the exclusion of balance contraints which happened was altering the optimization quite significantly.

@FabianHofmann FabianHofmann merged commit b6b18ad into master Jan 16, 2025
12 checks passed
@FabianHofmann FabianHofmann deleted the test-objective branch January 16, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants