Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make previous OSM versions compatible #1495

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Jan 15, 2025

Changes proposed in this Pull Request

Previous OSM prebuilts did not work because of the new data field map which is only available for OSM version >= 0.6. Fix this by making a case distinction.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: no_logs_found
  • fix-osm-versions failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix-osm-versions (f1df0cc) with master (27643f7).
Branch is 2 commits ahead and 10 commits behind.
Last updated on 2025-01-15 09:49:34 CET.

@FabianHofmann FabianHofmann merged commit 62afc9e into master Jan 15, 2025
12 checks passed
@FabianHofmann FabianHofmann deleted the fix-osm-versions branch January 15, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants