Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when checking if attribute has been changed, compare attribute name w… #106

Merged
merged 1 commit into from
Dec 12, 2023
Merged

when checking if attribute has been changed, compare attribute name w… #106

merged 1 commit into from
Dec 12, 2023

Conversation

nahumtimerman
Copy link
Contributor

…ithout shell namespace

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nahumtimerman
Copy link
Contributor Author

@alexquali seems like for 2nd gen shells, need to compare attribute name w/o namespace
@yaniv-k @Costya-Y

@Costya-Y Costya-Y changed the base branch from master to dev December 12, 2023 19:16
@Costya-Y Costya-Y changed the base branch from dev to master December 12, 2023 19:20
@Costya-Y Costya-Y changed the base branch from master to dev December 12, 2023 19:21
@Costya-Y Costya-Y merged commit c944926 into QualiSystems:dev Dec 12, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahumtimerman @Costya-Y