Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a PyPI upload action #43

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Add a PyPI upload action #43

merged 9 commits into from
Jul 4, 2024

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Jul 4, 2024

Checklist

  • Added a CHANGELOG.rst entry

@kklein kklein marked this pull request as ready for review July 4, 2024 11:50
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (6b33115) to head (5e39cf4).
Report is 42 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          14       14           
  Lines        1365     1365           
=======================================
  Hits         1297     1297           
  Misses         68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pavelzw
pavelzw reviewed Jul 4, 2024
View reviewed changes
.github/workflows/package.yml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pavelzw
pavelzw approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as OIDC is set up properly, this looks good 👍🏻

@kklein kklein merged commit 680553f into main Jul 4, 2024
14 checks passed
@kklein kklein deleted the pypi-action branch July 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelzw pavelzw pavelzw approved these changes

@FrancescMartiEscofetQC FrancescMartiEscofetQC FrancescMartiEscofetQC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kklein @pavelzw @FrancescMartiEscofetQC