Symbiflow write xxx #548
Merged
Symbiflow write xxx #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cd}: don't use env var and hardcode in and out file. Use script args instead
…er,jlink,openocd}: pass in and out files. Drop buildir to target name, simplify command by using target rule name and depend file
|
Any news about this PR getting merged? |
|
True. Good idea to "ping" :-) This PR has been approved and checks have passed, why don't apply this ? |
|
@lnsharma, can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most of the
symbiflow_write_xxxuses env varTOP_Fexported byql_symbiflowto provides hardcoded path based on this variable for input and output file when it calls corresponding python scriptConsequently calling directly
make -f Makefile_symbiflowor using manually one of these script fails (as mentionned in #538) due to missingTOP_Fvar.This PR modify behaviour of this scripts to pass directly scripts parameters to the python script.
ql_symbiflowis also modified to pass correct arguments (ie .bit and target file).Note:
symbiflow_write_binaryis absent to the master branch andsymbiflow_write_jlinkheaderseems totally absent. This why corresponding rules are not modified