fix: store effects cleanup & projection siblings serialization #7228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19584fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-store-effects-cleanup
branch
from
3a95d94 to
dae54f6
Compare
Varixo
force-pushed
the
v2-store-effects-cleanup
branch
from
dae54f6 to
0403889
Compare
Varixo
force-pushed
the
v2-store-effects-cleanup
branch
from
a599e06 to
a6492f8
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
approved these changes
Jan 8, 2025
| clearEffects(subscriber, value, value.$effectDependencies$, i, container); | ||
| } | ||
|
|
||
| if (value.$effectDependencies$.length === 0) { |
There was a problem hiding this comment.
I wonder if it isn't better to take out the whole effects array, replace with null or an empty array (removes a bunch of guards), and process all the effects without splicing.
That way the new effects will register in a separate array and we don't need to do array manipulation the whole time.
There was a problem hiding this comment.
But we can't just remove all effects. I don't understand how we can do that without modifying the array
Varixo
force-pushed
the
v2-store-effects-cleanup
branch
from
a6492f8 to
19584fb
Compare
wmertens
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERIALIZEflag, which is a bug, because we did not serialize component props that were siblings of the projection