fix: find correct context after rendering empty array #7234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b23eef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-find-context-empty-array
branch
2 times, most recently
from
0d003fe to
0922571
Compare
Varixo
force-pushed
the
v2-find-context-empty-array
branch
from
0922571 to
b23eef2
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| @@ -141,7 +141,7 @@ export class SsrComponentFrame implements ISsrComponentFrame { | |||
| if (isJSXNode(children)) { | |||
| const slotName = this.getSlotName(children); | |||
| mapArray_set(this.slots, slotName, children, 0); | |||
| } else if (Array.isArray(children)) { | |||
There was a problem hiding this comment.
I'm a bit confused. The test mentions we should add slot information for an empty array, but in ssr node we're adding an additional guard to only execute when it's not empty.
There was a problem hiding this comment.
yeah, the code which is responsible to add this is below in the else block :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem with slot prop for ssr. Empty arrays should be considered as empty content.