[kratos] Add Ory Kratos service #266
Conversation
pvannierop
force-pushed
the
ory-kratos
branch
4 times, most recently
from
00fa56e to
bdc9be3
Compare
helmfile.d/15-ory.yaml
Outdated
| @@ -0,0 +1,85 @@ | |||
| bases: | |||
There was a problem hiding this comment.
Since Ory is needed for all installations let's add it to 10-base.yaml instead of having its own separate file
There was a problem hiding this comment.
Can't the same be said about Management Portal? It is in its own file. As an alternative, we can rename 10-managementportal.yaml to 10-authentication.yaml or 10-identity-management.yaml and add both MP and Ory-Kratos. What do you think?
There was a problem hiding this comment.
In general I'd like to reduce number of helmfiles and merge them whenever it makes sense. I'm fine with changing the names, maybe we can merge both MP and Ory into 10-base.yaml.
If you won't want to put them into 10-base.yaml, since MP and appconfig aren't only about authentication or identity management I think we should have a more descriptive name.
There was a problem hiding this comment.
IMO, put it in 10-base.yaml.
app-config is the most optional but you can still disable it. I don't think there is a big benefit to it being in a separate helmfile
There was a problem hiding this comment.
Because postgres is difined in the 10-managementporta.yaml file, I moved kratos to this helmfile.
|
|
||
| courier: | ||
| smtp: | ||
| from_address: [email protected] |
There was a problem hiding this comment.
This should be configurable
There was a problem hiding this comment.
But it is configurable, right?
There was a problem hiding this comment.
It is but I think it should be in base.yaml since it will be changed in every installation.
There was a problem hiding this comment.
Ok the most simple solution would be to write this entry in base.yaml like so:
kratos:
_install: true
_chart_version: 0.43.0
_extra_timeout: 0
....
kratos:
courier:
smtp:
from_address: [email protected]
However, since SMTP settings are also used by MP (and possibly other services), we should consider defining this as global properties and inject this in the set: section of helmfile where needed.
helmfile.d/15-ory.yaml
Outdated
|
|
||
| releases: | ||
| - name: kratos | ||
| chart: ory/kratos |
There was a problem hiding this comment.
Please mirror the chart in external directory of radar-helm-charts and refer it from there similar to other external charts
There was a problem hiding this comment.
I copied the Ory helm charts the radar-helm-charts repo. The PR is here. I updated the chart references in 15-ory.html accordingly.
There was a problem hiding this comment.
Thanks, please also do a quick check if kratos can be successfully installed from our mirror
There was a problem hiding this comment.
@mpgxvii Did you ever install kratos using the latest radar-kubernetes and helm chart?
PR feedback Keyvan.
PR feedback Keyvan.
PR feedback Keyvan.
PR feedback Keyvan.
PR feedback Keyvan.
|
There seems to be an issue with the Kratos migration |
|
@keyvaann Yes, the problem was that we moved the kratos definitions to the 10-base.yaml file, but the postgres dependency was only defined in 10-managementportal.yaml. I corrected this and now it installs fine. |
Description of the change
This PR will add the Ory Kratos service. The Ory Kratos service will be the new solution for User and Identity management in RADAR-base.