-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capacitor Healthkit fixes #1765
base: dev
Are you sure you want to change the base?
Conversation
… query healthkit data while processing cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @mpgxvii. I can confirm the performance is much better now and It can handle multiple years of high-frequency wearable data.
Please find some comments below.
src/app/core/services/kafka/converters/healthkit-converter.service.ts
Outdated
Show resolved
Hide resolved
src/app/core/services/kafka/converters/key-converter.service.ts
Outdated
Show resolved
Hide resolved
src/app/pages/questions/components/question/text-input/text-input.component.ts
Outdated
Show resolved
Hide resolved
health_time: any | ||
|
||
notSupported = false | ||
READ_PERMISSIONS = DefaultHealthkitPermissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this configurable per project using remote config too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I've updated it so that the permissions requested depend on the field names (or in this case the healthkit data types).
BLOOD_PRESSURE_SYSTOLIC = 'blooPressureSystolic', | ||
BLOOD_PRESSURE_DIASTOLIC = 'bloodPressureDiastolic', | ||
RESTING_HEART_RATE = 'restingHeartRate', | ||
RESPIRATORY_RATE = 'respiratoryRate' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be good to add documentation (either readme or wiki) on how to add new data types as and when they are supported by the capacitor plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updated here: 9c15e7f
… into healthkit-capacitor
onResume
to only refresh screen when on home page