Capacitor Healthkit fixes #1765

mpgxvii · 2024-03-08T16:41:12Z

Store only poll times/offsets in cache rather than the complete healthkit data (since this is in the phone already)
This prevents storing and fetching of large amounts of data from storage (since we can pull this directly from HealthKit)
Currently supported datatypes:

export enum HealthkitDataType {
  STEP_COUNT = 'stepCount',
  FLIGHTS_CLIMBED = 'flightsClimbed',
  DISTANCE_WALKING_RUNNING = 'distanceWalkingRunning',
  DISTANCE_CYCLING = 'distanceCycling',
  ACTIVE_ENERGY_BURNED = 'activeEnergyBurned',
  BASAL_ENERGY_BURNED = 'basalEnergyBurned',
  HEART_RATE = 'heartRate',
  APPLE_EXERCISE_TIME = 'appleExerciseTime',
  BLOOD_GLUCOSE = 'bloodGlucose',
  SLEEP_ANALYSIS = 'sleepAnalysis',
  WEIGHT = 'weight',
  WORKOUT_TYPE = 'workoutType'
}

Also refactors sending of data to kafka: now converts to kafka object and sends for every object that gets converted, rather than waiting for all kafka objects to complete conversion/processing
Updated onResume to only refresh screen when on home page

… query healthkit data while processing cache

…nnaire

… into healthkit-capacitor

…parallel

… size

yatharthranjan

Amazing work @mpgxvii. I can confirm the performance is much better now and It can handle multiple years of high-frequency wearable data.

Please find some comments below.

src/app/core/services/kafka/cache.service.ts

src/app/core/services/kafka/converters/healthkit-converter.service.ts

src/app/core/services/kafka/converters/converter.service.ts

src/app/core/services/kafka/converters/key-converter.service.ts

src/app/core/services/kafka/kafka.service.ts

src/app/pages/questions/components/question/text-input/text-input.component.ts

yatharthranjan · 2024-12-19T15:42:10Z

src/app/pages/questions/services/healthkit.service.ts

-  health_time: any
-
-  notSupported = false
+  READ_PERMISSIONS = DefaultHealthkitPermissions


should we make this configurable per project using remote config too?

Ah yes I've updated it so that the permissions requested depend on the field names (or in this case the healthkit data types).

src/app/pages/questions/services/questions.service.ts

yatharthranjan · 2024-12-19T18:35:29Z

src/app/shared/models/health.ts

+  BLOOD_PRESSURE_SYSTOLIC = 'blooPressureSystolic',
+  BLOOD_PRESSURE_DIASTOLIC = 'bloodPressureDiastolic',
+  RESTING_HEART_RATE = 'restingHeartRate',
+  RESPIRATORY_RATE = 'respiratoryRate'


Perhaps it would be good to add documentation (either readme or wiki) on how to add new data types as and when they are supported by the capacitor plugin.

Yes, updated here: 9c15e7f

src/assets/data/defaultConfig.ts

… into healthkit-capacitor

mpgxvii added 2 commits March 8, 2024 16:40

fix(healthkit): Initial changes to only store poll times in cache and…

0450c86

… query healthkit data while processing cache

Refactor healthkit converter so that data is pulled after the questio…

a8e5dd4

…nnaire

mpgxvii marked this pull request as ready for review March 18, 2024 19:15

Base automatically changed from update-deps to dev March 18, 2024 19:40

mpgxvii added 5 commits March 19, 2024 11:08

Merge branch 'dev' of https://github.com/RADAR-base/RADAR-Questionnaire…

d3a5288

… into healthkit-capacitor

fix: remove hardcoded datatypes and pull healthkit topics from enums

48e56fa

fix: update Healthkit topics

3f3592d

fix: cleanup and fix tests

12ee55b

fix: default config

2b0de26

mpgxvii requested review from yatharthranjan and peyman-mohtashami March 19, 2024 16:08

mpgxvii added 6 commits April 1, 2024 16:15

fix: add slide transition check before processing data

29eba8a

fix: add healthkit lookback interval to remote config

bbee8a9

fix: chunk healthkit data into batches to be within gateway limit

be64063

feat: add initial finish screen loading animation

580ad8c

fix: progress bar animation

42b0b11

fix: permissions

f6c6578

mpgxvii removed request for yatharthranjan and peyman-mohtashami April 19, 2024 10:22

mpgxvii marked this pull request as draft April 19, 2024 10:22

mpgxvii added 10 commits April 22, 2024 17:33

fix: update deps and Android config

488d317

chore: update package-lock.json

5fe7c54

fix: use multipleQueryHKitSampleType to query multiple data types in …

8ed63f1

…parallel

fix: merge conflicts

b985b6d

fix: qr code enrolment and remove smoothscroll polyfill

c87d1c0

chore: update deps for unit tests

be74ffd

fix(kafkaService): chunk records to smaller records if it exceeds max…

2e2b022

… size

fix: divide healthkit queries by batches

c075d52

fix: send progress data from kafka service to questions page

01ab0d1

fix: fix calculation of progress and show this in the component

74705c0

mpgxvii added 11 commits December 6, 2024 17:22

Decode iat in token if not present in response

57ab655

Fix settings page

09c4ba3

Use capacitor http for kafka requests

4d25822

Fix progress updating

422e698

Add additional healthkit data types

5e9071d

Add reset for schemas and converters

1e83472

Update healthkit converter to support unknown device info

f47dd25

Fix kafka service to support sending of large paylods

c40f3ba

Calculate minutes for sending estimated time

2b2ba1f

Add Healthkitconverter webworker to run conversion outside main thread

1b958f2

Update schedule year coverage

025b98f

yatharthranjan reviewed Dec 19, 2024

View reviewed changes

mpgxvii added 17 commits January 9, 2025 00:34

Merge branch 'dev' of https://github.com/RADAR-base/RADAR-Questionnaire…

88a8e3e

… into healthkit-capacitor

Fix package-lock.json

e5ad8a7

Remove unnecessary topic param in converterService

b1ed730

Fix healthkit sourcename delimiter

71e9466

Fix date input parsing

6827fcb

Update checking if healthkit input type

6942339

Update onResume to only refresh screen when on the HomePage

b9a4d74

Use hash key instead of uuid for cache key

1ab2e85

Fix package-lock.json

a1617cd

Remove unnecessary topic parameter in kafka converters

d6cf5ac

Add custom test polyfills

6dd04c2

Rename test polyfills

23d02b1

Use library for hashing instead of crypto

58d26e2

Update README with Healthkit docs

9c15e7f

Update README

317082c

Request Healthkit permissions based on datatype

9967d8e

Add KeyConverter abstract class

aa2a798

mpgxvii requested a review from yatharthranjan January 9, 2025 19:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capacitor Healthkit fixes #1765

Capacitor Healthkit fixes #1765

mpgxvii commented Mar 8, 2024 •

edited

Loading

yatharthranjan left a comment

yatharthranjan Dec 19, 2024

mpgxvii Jan 9, 2025

yatharthranjan Dec 19, 2024

mpgxvii Jan 9, 2025

Capacitor Healthkit fixes #1765

Are you sure you want to change the base?

Capacitor Healthkit fixes #1765

Conversation

mpgxvii commented Mar 8, 2024 • edited Loading

yatharthranjan left a comment

Choose a reason for hiding this comment

yatharthranjan Dec 19, 2024

Choose a reason for hiding this comment

mpgxvii Jan 9, 2025

Choose a reason for hiding this comment

yatharthranjan Dec 19, 2024

Choose a reason for hiding this comment

mpgxvii Jan 9, 2025

Choose a reason for hiding this comment

mpgxvii commented Mar 8, 2024 •

edited

Loading