Method registration fixes

R/generic.R

@@ -205,7 +205,9 @@ generic_add_method <- function(generic, signature, method) {
       p_tbl <- tbl
     } else {
       if (!is.null(p_tbl[[class_name]])) {
-        message("Overwriting method ", method_name(generic, signature))
+        if (!identical(p_tbl[[class_name]], method)) {
+          message("Overwriting method ", method_name(generic, signature))
+        }
       }
       p_tbl[[class_name]] <- method
     }

R/method-register.R

@@ -85,8 +85,8 @@ register_method <- function(generic,
   # if we're inside a package, we also need to be able register methods
   # when the package is loaded
   if (!is.null(package) && !is_local_generic(generic, package)) {
-    generic <- as_external_generic(generic)
-    external_methods_add(package, generic, signature, method)
+    external_generic <- as_external_generic(generic)
+    external_methods_add(package, external_generic, signature, method)
   }
 
   invisible(generic)

tests/testthat/_snaps/method-register.md

@@ -2,7 +2,7 @@
 
     Code
       method(foo, class_character) <- (function(x) "c")
-      method(foo, class_character) <- (function(x) "c")
+      method(foo, class_character) <- (function(x) "d")
     Message
       Overwriting method foo(<character>)
 

tests/testthat/test-method-register.R

@@ -10,7 +10,7 @@ describe("method registration", {
     foo <- new_generic("foo", "x")
     expect_snapshot({
       method(foo, class_character) <- function(x) "c"
-      method(foo, class_character) <- function(x) "c"
+      method(foo, class_character) <- function(x) "d"
     })
     expect_length(methods(foo), 1)
   })