Revert "sock/udp: work around gnrc_sock_recv() returning early timeout" #21126
+1
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e3d0068, which added a work around for two bugs: - ztimer triggering too early (fixed in RIOT-OS#20924) - gnrc_sock_recv() returning when an old "timeout" message is still in the message queue (fixed in RIOT-OS#21113) With those bugs fixed, the work around should not longer be needed.
maribu
added
Type: cleanup
|
I am assuming that it is intentional that you did not revert the other commit (c4634f5) in the referenced PR, but would like confirmation that it wasn't forgotten. |
|
I can later run |
|
I assumed something along those lines. If you don't get to it today, I will likely attempt to generate the makefile tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This reverts commit e3d0068, which added a work around for two bugs:
With those bugs fixed, the work around should not longer be needed.
Testing procedure
@benpicco has a test setup with dozen of native instances.
Issues/PRs references
#19965