Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] fix failed error bugs in conv backward weight solvers #2770

Merged
merged 6 commits into from
Mar 4, 2024
Merged

[HotFix] fix failed error bugs in conv backward weight solvers #2770

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
726ff42
fix failed error bugs in 2d/3d conv backward weight solvers
iq136boy Feb 24, 2024
81f29c0
fix time issue in NCHW layout invoker
iq136boy Feb 29, 2024
f6f67d5
code refactoring: define hip event profiler to reduce code duplicate
iq136boy Mar 1, 2024
ec136ac
delete comments
iq136boy Mar 1, 2024
86549f6
fix tidy error
iq136boy Mar 1, 2024
1fb3360
address comments
iq136boy Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 37 additions & 19 deletions src/include/miopen/solver/implicitgemm_ck_util.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <miopen/conv/data_invoke_params.hpp>
#include <miopen/conv/wrw_invoke_params.hpp>
#include <miopen/batched_transpose_sol.hpp>
#include <miopen/tensor_ops.hpp>

#if MIOPEN_USE_COMPOSABLEKERNEL
#include <ck/utility/data_type.hpp>
Expand Down Expand Up @@ -96,6 +97,31 @@ bool IsCKApplicable(const ProblemDescriptionType& problem)
ptrs.begin(), ptrs.end(), [&args](auto& ptr) { return args.IsSupportedBy(ptr); });
}

#define WORKAROUND_CK_ISSUE_1184 1
#if WORKAROUND_CK_ISSUE_1184
struct HipEventProfiler
{
const Handle& handle;
float event_time;
HipEventPtr start;
HipEventPtr stop;

HipEventProfiler(const Handle& handle_)
: handle(handle_), event_time(0.0f), start(make_hip_event()), stop(make_hip_event())
{
hipEventRecord(start.get(), handle.GetStream());
}
~HipEventProfiler()
{
hipEventRecord(stop.get(), handle.GetStream());
hipEventSynchronize(stop.get());
hipEventElapsedTime(&event_time, start.get(), stop.get());
handle.ResetKernelTime();
handle.AccumKernelTime(event_time);
}
};
#endif

template <typename DeviceOpType,
typename CKArgsType,
typename CastType,
Expand All @@ -122,14 +148,15 @@ ConvSolution InitInvokerFactoryNHWC(const ExecutionContext&,
const auto& data_ctx = primitive_parameters.CastTo<CastType>();
auto argument_ptr = ck_args.MakeArgPtr(sh_conv_ptr, data_ctx.tensors);
auto invoker_ptr = sh_conv_ptr->MakeInvokerPointer();

const auto enable_profiling = handle.IsProfilingEnabled();
float elapsed_time =
invoker_ptr->Run(argument_ptr.get(), {handle.GetStream(), enable_profiling});
if(enable_profiling)
{
handle.ResetKernelTime();
handle.AccumKernelTime(elapsed_time);
HipEventProfiler pfr(handle);
if constexpr(std::is_same<CastType, miopen::conv::WrWInvokeParams>::value)
{
auto zero = 0.0f;
const auto& tensors = data_ctx.tensors;
SetTensor(handle, tensors.dwDesc, tensors.dw, &zero);
}
invoker_ptr->Run(argument_ptr.get(), {handle.GetStream(), false});
}
};
};
Expand Down Expand Up @@ -605,15 +632,14 @@ ConvSolution InitInvokerFactoryNCHW(const ExecutionContext& ctx,
std::swap(conv_tensors.x, conv_tensors.y);
std::swap(conv_tensors.xDesc, conv_tensors.yDesc);
}

HipEventProfiler pfr(handle);
input1_tr_inst.ConvertFrom(handle, kernels, conv_tensors);

input2_tr_inst.ConvertFrom(handle, kernels, conv_tensors);

output_init_tr_inst.ConvertFrom(handle, kernels, conv_tensors);

/// \todo: Fix NHWC Wrw invokers to also issue a zero-out kernel. Will
/// need SetTensor() to properly zero out non-packed tensors
iq136boy marked this conversation as resolved.
Show resolved Hide resolved
/// \todo: Will need SetTensor() to properly zero out non-packed tensors
if(output_tr_inst.GetConvOperandTag() == internal::ConvOperandTag::Weights)
{
output_tr_inst.ZeroOutBuffer();
Expand All @@ -632,15 +658,7 @@ ConvSolution InitInvokerFactoryNCHW(const ExecutionContext& ctx,
tr_ptrs[0]->GetBufferPtr(),
tr_ptrs[1]->GetBufferPtr(),
tr_ptrs[2]->GetBufferPtr());
float conv_time = 0;
conv_time += invoker_ptr->Run(argument_ptr.get(),
{handle.GetStream(), handle.IsProfilingEnabled()});

if(handle.IsProfilingEnabled())
{
handle.AccumKernelTime(conv_time);
}

invoker_ptr->Run(argument_ptr.get(), {handle.GetStream(), false});
output_tr_inst.ConvertTo(handle, kernels, conv_tensors);
};
};
Expand Down