[HIP][LDS] Adding HIP LDS Regression Tests. #1211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampandey-AMD
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
|
ping @b-sumner for review of HIP LDS and device malloc/free overflow test cases. |
b-sumner
requested changes
Jan 10, 2025
| @@ -28,6 +28,7 @@ int main(int argc, char *argv[]) { | |||
| hipCallSuccessfull(hipMalloc(&D_Ptr, NBytes)); | |||
| hipLaunchKernelGGL(TestKernel, dim3(NumOfThreadBlocks), dim3(ThreadBlockSize), | |||
| 0, 0, N, D_Ptr); | |||
| hipDeviceSynchronize(); | |||
| return error == hipSuccess; | ||
| } | ||
|
|
||
| __device__ void OffloadToGPU(int *d_ptr){ |
There was a problem hiding this comment.
TestFunction might be a better name than OffloadToGPU
| return error == hipSuccess; | ||
| } | ||
|
|
||
| __device__ void OffloadToGPU(int *d_ptr, __shared__ int *lds_ptr) { |
| return error == hipSuccess; | ||
| } | ||
|
|
||
| __device__ void OffloadToGPU(int *d_ptr){ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.