-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/2.5] [SWDEV-497569] Ignore backend-specific args in the TTIR analysis (#141… #1768
base: release/2.5
Are you sure you want to change the base?
Conversation
…rch#141062) Fixes pytorch#140800. On AMD, backend-specific args like `matrix_instr_nonkdim`, `waves_per_eu` and `kpack` are passed either direclty to the kernel or via `triton.Config`, whereas they don't exist as kernel parameters. Native Triton code handles those excessive args [here](https://github.com/triton-lang/triton/blob/a6bb57d6285e723c58e87dd7cba263db6efff789/python/triton/runtime/jit.py#L594-L596). In this PR, we add similar handling to the TTIR analysis code to avoid bailing out. Pull Request resolved: pytorch#141062 Approved by: https://github.com/oulgen (cherry picked from commit b740a1b)
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
@pruthvistony can we merge this to close a JIRA. |
Jenkins build for 304a97ee6f4f9d08c6ec2e0e96d0de7ccd9d79f7 commit finished as FAILURE |
Fixes pytorch#140800.
On AMD, backend-specific args like
matrix_instr_nonkdim
,waves_per_eu
andkpack
are passed either direclty to the kernel or viatriton.Config
, whereas they don't exist as kernel parameters. Native Triton code handles those excessive args here. In this PR, we add similar handling to the TTIR analysis code to avoid bailing out. Pull Request resolved: pytorch#141062 Approved by: https://github.com/oulgen(cherry picked from commit b740a1b)
Fixes #ISSUE_NUMBER