Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rocm6.4_internal_testing] remove xfail from 'batch_norm_with_update' #1821

Conversation

dnikolaev-amd
Copy link

remove xfail from batch_norm_with_update op in test_grad and test_vmap_autograd_grad
these tests are passed now
Fixes https://ontrack-internal.amd.com/browse/SWDEV-472564
cherry-picked from rocm6.3_internal_testing PR #1776

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 9, 2025

Jenkins build for 94aacd73b2b504110e61c257d541b77019d97b10 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@pruthvistony pruthvistony merged commit 99b0758 into rocm6.4_internal_testing Jan 9, 2025
1 check failed
@pruthvistony pruthvistony deleted the dnikolae/rocm6.4_remove_xfail_for_batch_norm_with_update branch January 9, 2025 02:48
rocm-mici pushed a commit that referenced this pull request Jan 9, 2025
…#1821)

remove `xfail` from `batch_norm_with_update` op in `test_grad` and
`test_vmap_autograd_grad`
these tests are passed now
Fixes https://ontrack-internal.amd.com/browse/SWDEV-472564
cherry-picked from rocm6.3_internal_testing PR
#1776
@ROCm ROCm deleted a comment from rocm-mici Jan 9, 2025
rocm-mici pushed a commit that referenced this pull request Jan 9, 2025
…#1821)

remove `xfail` from `batch_norm_with_update` op in `test_grad` and
`test_vmap_autograd_grad`
these tests are passed now
Fixes https://ontrack-internal.amd.com/browse/SWDEV-472564
cherry-picked from rocm6.3_internal_testing PR
#1776
@ROCm ROCm deleted a comment from rocm-mici Jan 9, 2025
@inemankov
Copy link

!cherry-pick --onto rocm6.3_internal_testing

@ROCm ROCm deleted a comment from rocm-mici Jan 9, 2025
rocm-mici pushed a commit that referenced this pull request Jan 9, 2025
…#1821)

remove `xfail` from `batch_norm_with_update` op in `test_grad` and
`test_vmap_autograd_grad`
these tests are passed now
Fixes https://ontrack-internal.amd.com/browse/SWDEV-472564
cherry-picked from rocm6.3_internal_testing PR
#1776
@rocm-mici
Copy link

Created branch rocm6.3_internal_testing_cherry-pick_pr-1821 and #1825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants