Refactor dispatch #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianfengz
approved these changes
Dec 5, 2024
Comment on lines
13
to
27
| template <bool v> | ||
| struct has_mask_t : ck_tile::bool_constant<v> {}; | ||
|
|
||
| template <bool v> | ||
| struct has_bias_t : ck_tile::bool_constant<v> {}; | ||
|
|
||
| template <bool v> | ||
| struct has_dropout_t : ck_tile::bool_constant<v> {}; | ||
|
|
||
| template <ck_tile::index_t v> | ||
| struct max_head_dimension_t : ck_tile::integral_constant<ck_tile::index_t, v> { | ||
| }; | ||
|
|
||
| template <ck_tile::index_t v> | ||
| struct max_query_seqlen_t : ck_tile::integral_constant<ck_tile::index_t, v> {}; |
There was a problem hiding this comment.
Can you put these definitions in a common file ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mark the template dispatch parameters with named types to make the compiled symbols more readable.
E.g.
batched_infer_mask_bias_dropout_dispatch<unsigned short, has_mask_t<true>, has_bias_t<false>, has_dropout_t<true>, max_head_dimension_t<64> >::Run(...instead ofbatched_infer_mask_bias_dropout_dispatch<unsigned short, true, false, true, 64 >::Run(Also enable offload compression to reduce the compiled binary size approximately 2x
Fix CI issues related to build failures (WIP)
Fix lints