Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inline recs): Fix mb.org exclude rules and add mb.eu match rule #777

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jesus2099
Copy link
Contributor

@jesus2099 jesus2099 commented Jul 20, 2024

Exclude rule syntax is like include, not like match (//*.mb.org does not match //mb.org, only test.mb.org, beta.mb.org) Before this commit, exclude rules are not applied to main //mb.org website

I am also excluding more unrelated pages (open edits, edit history page 2+, details, cover arts, ...)

Add mb.eu support


@ROpdebee, may I leave you manage the version number, OK?
My 3 concurrent PR have no conflict between themselves:

Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

I think I had also noticed the errors caused by this userscript running on release editor pages when I was debugging release seeding but was too lazy to fix this myself 😅

@kellnerd kellnerd added bug Something isn't working mb_qol_inline_recording_tracks labels Jul 21, 2024
@kellnerd kellnerd changed the title fix(inline recs): Fix mb.org eclude rules and add mb.eu match rule fix(inline recs): Fix mb.org exclude rules and add mb.eu match rule Jul 21, 2024
Exclude rule syntax is like include, not like match
(//*.mb.org does not match //mb.org, only test.mb.org, beta.mb.org)
Before this commit, exclude rules are not applied to main //mb.org website

I am also excluding more unrelated pages
(open edits, edit history page 2+, details, cover arts, ...)

Add mb.eu support
@jesus2099 jesus2099 force-pushed the fix-match-and-exclude-rules branch from 9338e7c to 392564b Compare July 22, 2024 11:30
@jesus2099
Copy link
Contributor Author

Thanks for spotting the typo, I have now just fixed it in the commit text itself, as well.

@kellnerd kellnerd merged commit 1b00d49 into ROpdebee:main Jul 25, 2024
11 checks passed
@jesus2099 jesus2099 deleted the fix-match-and-exclude-rules branch July 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants