fix(inline recs): Handle video recordings #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `:first-child`, not needed and blocking video recordings detection The selector is already strict enough to not catch recordings from `div.ars` (I guess it was the reason for those) Example where video data track was not handled before this commit: https://musicbrainz.org/release/d9e494dd-9386-48e4-8c52-9764dd8b8a0f There was not problem with non-video data tracks: https://musicbrainz.org/release/b63ca2ff-782e-45fc-bfb9-b74dc6aefe00
This was referenced Jul 20, 2024
kellnerd
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
:first-child, not needed and blocking video recordings detectionThe selector is already strict enough to not catch recordings from
div.ars(I guess it was the reason for those)Examples where video data track was not handled before this commit: https://musicbrainz.org/release/d9e494dd-9386-48e4-8c52-9764dd8b8a0f
https://musicbrainz.org/release/0a5be94f-3429-46bd-9b1d-07dcb0209098
Release with recordings in inline relationships (on CD 23): https://musicbrainz.org/release/70dcde39-81ed-45e8-bdb3-f511112a3880
There was not problem with non-video data tracks:
https://musicbrainz.org/release/b63ca2ff-782e-45fc-bfb9-b74dc6aefe00
@ROpdebee, may I leave you manage the version number, OK?
My 3 concurrent PR have no conflict between themselves: