-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inline recs): Crash when no existing div.ars #763
Conversation
I don't understand why my PR fails a test. |
Initially I forked repo to see if I could exclude current track from the inline track list. Also I thought inline track list should be ordered, at least alphabetically (including the medium.track numbers). * Current track, not current recording. As some releases have the same recording on several tracks. |
Example release with no ARs https://musicbrainz.org/release/1f3a402f-7265-42ea-803a-f3cf8c508e7c Or any other releases with credits at bottom and no mb_INLINE-STUFF running https://musicbrainz.org/release/b4e8f7f4-e35c-42eb-a043-9605e4784aff
BTW I just noticed that that release had tracks with both |
No worries, it is the latest commit in main which is currently failing the code coverage test (because a few Discogs tests had to be disabled temporarily). |
…pped Tracks with pending edits and different title as recording have both span.mp and span.name-variation. <td><span class="mp"><span class="name-variation"><a href="/recording/... Only one level of span (either .mp or .name-variation) was handled.
Thanks for the fixes! |
@ROpdebee, you forgot the mb_qol_inline_recording_tracks label, that you can also add to #764. |
I noticed that this userscript relies on mb_INLINE-STUFF to run properly.
Example release with no AR, no AcoustID and no ISRC (quick! it is being removed!)
https://musicbrainz.org/release/1f3a402f-7265-42ea-803a-f3cf8c508e7c
Or any other releases with credits at bottom and no mb_INLINE-STUFF running
https://musicbrainz.org/release/b4e8f7f4-e35c-42eb-a043-9605e4784aff