Adds RecordBuilder.Options.defaultNotNull parameters #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for putting together record-builder! It's definitely a welcome addition and enhancement on top of
record
s.Issue/Enhancement
Some codebases expect fields to be non-null by default, for example if NullAway enforcement is in place. Therefore it is useful to set a parameter to expect that all fields will be non-null unless explicitly marked as nullable.
Currently our codebase uses https://immutables.github.io/immutable.html which defaults to non-null fields, and it would be good to have record-builder have the capability for the same behaviour.
Changes
Adds the ability to default fields to be non-null, unless they are annoted with a nullable annotation, ie:
Example
For example:
will check/ensure that
notNullInteger
andnotNullString
are not null viarequireNonNull
calls.Questions
javax.annotation.ParametersAreNonnullByDefault
? That might be a future enhancement.