Suggestion box #324
Suggestion box #324
Conversation
SeHarlan
requested review from
domitriusclark,
magnificode and
racedale
as code owners
|
Deploy request for rebuild-black-business accepted. Accepted with commit 591f2bf https://app.netlify.com/sites/rebuild-black-business/deploys/5f4436f548609a000a88e181 |
There was a problem hiding this comment.
@SeHarlan thank you so much for the work here! Left a few comments.
| } | ||
|
|
||
| return ( | ||
| <FormControl |
There was a problem hiding this comment.
It appears that this FormControl element is outputting a div instead of a <form> element. It appears that we may just need to manually wrap the form elements with <form netilfy> to get those form submissions working properly!
There was a problem hiding this comment.
Hey @SeHarlan - I'm not sure if this is just a challenge of testing the form on the deployment preview, but the form still doesn't get dropped into Netlify.
Do you mind trying one more thing for me? After looking at the documentation https://docs.netlify.com/forms/setup/#html-forms it appears that we may need a couple of additional attributes on the form. Primarily name and method.
Could you try adding the following:
name="suggestion-box"
and
method="POST"
Let's give this a shot, and if we still aren't getting form submissions through the deploy preview, we'll merge and see what we get :)
There was a problem hiding this comment.
It looks like Netlify is properly recognizing the form, the honeypot and some Netlify specific elements seem to be populating. I'm going to merge this and test the submissions on production!
|
@SeHarlan this looks great, thank you so much for the work! |
|
@all-contributors please add SeHarlan for code |
|
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token { in JSON at position 8547 |
|
@all-contributors please add SeHarlan for code |
|
I've put up a pull request to add @SeHarlan! 🎉 |
Describe your PR
Created a suggestion box/form that integrates with Netlify.
!! I've gotten a success message from Netlify, but as I don't have access to the dashboard I cannot fully confirm this !!
A user can access this form by clicking on the contact card I added on the about us page, it then pops open a modal with the form. Talking with Neil, we thought it might be best to remove the business registration contact card as there is essentially already a whole page dedicated to it. I've left the code for it commented out in case we want to bring it back though.
The original issue also mention sending an email to some rbb email account, I have not done that part but can tackle it if we want to add that as well. It would just mean creating a service function and calling it in the handleSubmit func in SuggestionBox.js
I've also added titles to the other forms for consistency
Related to #283
Fixes #283
Pages/Interfaces that will change
added SuggestionBox.js in Forms folder
about.js
ContactCard.js
BusinessSignUpForm.js
AllySignUpForm.js
Screenshots / video of changes
Before:
After:
Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom
Steps to test
Additional notes