Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RI-6540: Change message for unsupported data types #248

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RI-6540: Change message for unsupported data types #248

wants to merge 2 commits into from

Conversation

pawelangelow
Copy link
Collaborator

Preview

Screenshot 2025-01-08 at 11 51 08 Screenshot 2025-01-08 at 11 51 13

@pawelangelow pawelangelow self-assigned this Jan 8, 2025
egor-zalenski
egor-zalenski requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@egor-zalenski egor-zalenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after changing texts we should call yarn l10n:collect to update the texts lists

egor-zalenski
egor-zalenski approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@egor-zalenski egor-zalenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for future:
branches for vscode extension should start with feature/* to autorun fe unit tests

@pawelangelow
Copy link
Collaborator Author

Ty for the suggestion. Here's the action results from running the tests: https://github.com/RedisInsight/Redis-for-VS-Code/actions/runs/12673008836/job/35318351238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-zalenski egor-zalenski egor-zalenski approved these changes

Assignees

@pawelangelow pawelangelow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelangelow @egor-zalenski