Fix inconsistency of plugin code build when packaging for Marketplace/Fab #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Fab This fixes an issue where the editor would not be built if there were no tests to run for a package plugin, even though the editor was explicitly included in the build list for the distribution in BuildConfig.json. As of this change, the build steps are always run based on what's in BuildConfig.json, but if the package type is set to 'None', then the binaries from these build steps don't get included in the packaged plugin for tests (so they'll be built again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the editor would not be built if there were no tests to run for a package plugin, even though the editor was explicitly included in the build list for the distribution in BuildConfig.json.
As of this change, the build steps are always run based on what's in BuildConfig.json, but if the package type is set to 'None', then the binaries from these build steps don't get included in the packaged plugin for tests (so they'll be built again).