Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripme now counts files as already download (for the history.end_rip_a… #1298

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cyian-1756
Copy link
Collaborator

…fter_already_seen feature) if they appear on disk and not in the url history file

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

This change allows ripme to count files that exist on disk but were never added to the url history file to be counted as already downloaded.

This allows user to use the history.end_ripe_after_already_seen feature without needing to save a list of all files the user has downloaded

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

cyian-1756 added 3 commits May 6, 2019 00:37
@cyian-1756
Copy link
Collaborator Author

In it's current state this breaks the GUI and should not be merged

@cyian-1756
Copy link
Collaborator Author

This PR is being blocked by the bug first reported in #26.

@cyian-1756
Copy link
Collaborator Author

If anyone else can test this it would be a great help. The issue I've run into is that even tho the GUI reports the rip has ended, it keeps ripping in the background.

To test this

  1. Disable url history

  2. rip a series of albums and then rerip them, allowing the history.end_rip_after_already_seen feature to end the rip

  3. Watch the terminal output to see if it keeps ripping in the background

@metaprime metaprime changed the base branch from master to main January 6, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant