Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook ripper created #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Facebook ripper created #15

wants to merge 1 commit into from

Conversation

lukepayne
Copy link
Contributor

@lukepayne lukepayne commented Jul 9, 2017 •
edited
Loading

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Facebook ripper

Testing

To be done

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

rautamiekka
rautamiekka reviewed Jul 9, 2017
View reviewed changes
src/main/java/com/rarchives/ripme/ripper/rippers/FacebookRipper.java
waitForThreads();
}

@Override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra indent.

rautamiekka
rautamiekka reviewed Jul 9, 2017
View reviewed changes
src/main/java/com/rarchives/ripme/ripper/rippers/FacebookRipper.java
}

private ArrayList<String> getPhotosFromAlbum(String albumID) throws IOException {
ArrayList<String> photoIDS = new ArrayList<String>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra indent.

@lukepayne
Copy link
Contributor Author

Ugh.. I'm trying out VS Code and these indents didn't appear in the editor.

@metaprime
Copy link
Contributor

metaprime commented Jul 13, 2017 •
edited
Loading

@lukepayne I mainly use VS Code for Ripme. It's good until you need a debugger, in which case Eclipse seems to be the least bad option. Debugging projects built with Maven isn't that well-supported across the board, it seems.

In VS Code, try turning on whitespace markers in the settings ("editor.renderWhitespace": "boundary") and make your indentation settings so that you use spaces (4 per tabstop), not tabs.

@heyhippari
Copy link
Contributor

Is this still maintained ?

I have a slightly modified version of this on a local branch that I plan on upgrading once the Facebook API is open again (They closed a lot of stuff with the Cambridge Analytica situation).

@lukepayne
Copy link
Contributor Author

@MrTimscampi Feel free to take and build on this, I haven't looked at it in some time.

@heyhippari
Copy link
Contributor

@lukepayne Unfortunately, i'm a bit busy with work and other projects, these days :/

@soloturn
Copy link
Collaborator

soloturn commented Jan 6, 2019

Ugh.. I'm trying out VS Code and these indents didn't appear in the editor.

in such cases i tend to use editorconfig:
https://github.com/editorconfig/editorconfig-vscode

@metaprime metaprime changed the base branch from master to main January 5, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautamiekka rautamiekka rautamiekka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukepayne @metaprime @heyhippari @soloturn @rautamiekka