Fix the benchmarks datasets URL format #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the review! |
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
225: Fix the benchmarks datasets URL format r=Kerollmops a=Kerollmops We were using an URL of the form _git://github.com/orga/repo.git_ which is wrong and GitHub broke it recently. I just changed it to make it valid by using the https://github.com/orga/repo.git format. This PR also changes the version of `retain_mut` to _=0.1.7_ to avoid CI-breaking warnings. If you want to understand the reason why I am doing that you can read more in RoaringBitmap#224. Co-authored-by: Kerollmops <[email protected]>
bors bot
added a commit
that referenced
this pull request
Sep 1, 2022
222: Introduce `insert_range` for RoaringTreemap r=Kerollmops a=not-jan Implemented a somewhat naive version of `insert_range` for RoaringTreemap ~~I wanted to add a separate benchmark to compare the performance of `insert_range` with collecting from an iterator but was unable to do so because `cargo bench` would fail with a connection error every time I ran it.~~ **Edit:** This is fixed now with #225 Co-authored-by: saik0 <[email protected]> Co-authored-by: not-jan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using an URL of the form git://github.com/orga/repo.git which is wrong and GitHub broke it recently. I just changed it to make it valid by using the https://github.com/orga/repo.git format.
This PR also changes the version of
retain_mutto =0.1.7 to avoid CI-breaking warnings. If you want to understand the reason why I am doing that you can read more in #224.