Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more dynamic handling #128

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Conversation

ben47955
Copy link
Member

Change to indirect kick rule

rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
@arnemoos
Copy link
Contributor

I think the major part missing here is, that for each team there have to be two contacts within the same team, meaning this:

The ball must be deliberately played-at a second time by another robot of the same team before a goal may be scored.

@ben47955 ben47955 force-pushed the Dynamic-handling branch 2 times, most recently from 888f462 to dd2a508 Compare December 4, 2023 15:56
@rvilling
Copy link

rvilling commented Dec 4, 2023

Minor comment - the second competition is called "Challenge Shield" rather than "Challenger Shield"

@rvilling
Copy link

rvilling commented Dec 4, 2023

In conventional usage (outside RoboCup) a free kick means a different thing to kick-in, corner kick, etc.

I'd prefer to see "The attacking team may only score a goal via indirect kick from any restart into \texttt{playing} from a free kick." rephrased to list the set plays from which an indirect kick is required (or to say all set plays except for some specified ones).

@rvilling
Copy link

rvilling commented Dec 4, 2023

In the FIFA rules, the authors tend to list the full set of different set plays that applies in each case, e.g. "If the ball becomes defective at a kick-off, goal kick, corner kick, free kick, penalty kick or throw-in, the restart is retaken"

@arnemoos
Copy link
Contributor

@ben47955 maybe also have a look into issue #106

rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Show resolved Hide resolved
@ben47955
Copy link
Member Author

I made most change, I juste need to solve the two points in pending

rules/game_process.tex Outdated Show resolved Hide resolved
rules/game_process.tex Outdated Show resolved Hide resolved
@ben47955
Copy link
Member Author

I made the discussed change

rules/game_process.tex Outdated Show resolved Hide resolved
@ben47955
Copy link
Member Author

Updated

@arnemoos arnemoos merged commit 93014d7 into RoboCup-SPL:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants