Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger windows builds #14

Merged
merged 22 commits into from
Jan 9, 2025
Merged

Trigger windows builds #14

merged 22 commits into from
Jan 9, 2025

Conversation

Tobias-Fischer
Copy link
Contributor

Fix #12

@Tobias-Fischer
Copy link
Contributor Author

@traversaro: do you have any idea about this error in ros-jazzy-iceoryx-posh? I can't see any difference to the ros-humble version.

2025-01-06T03:31:21.7379884Z  │ │ [1/9] Creating directories for 'ext_cpptoml'
2025-01-06T03:31:22.8508358Z  │ │ [2/9] Performing download step (git clone) for 'ext_cpptoml'
2025-01-06T03:31:22.9460096Z  │ │ Cloning into 'src'...
2025-01-06T03:31:22.9463730Z  │ │ HEAD is now at fededad one-char typo
2025-01-06T03:31:22.9466682Z  │ │ Submodule 'deps/meta-cmake' (https://github.com/meta-toolkit/meta-cmake.git) registered for path 'deps/meta-cmake'
2025-01-06T03:31:22.9469410Z  │ │ Cloning into '%SRC_DIR%/build/dependencies/cpptoml/src/deps/meta-cmake'...
2025-01-06T03:31:22.9472292Z  │ │ Submodule path 'deps/meta-cmake': checked out 'db7ff976c430a6cb6cbd03ae691be04cfaac0a07'
2025-01-06T03:31:22.9474441Z  │ │ [3/9] Performing update step for 'ext_cpptoml'
2025-01-06T03:31:22.9841180Z  │ │ -- Already at requested tag: v0.1.1
2025-01-06T03:31:22.9842970Z  │ │ [4/9] No patch step for 'ext_cpptoml'
2025-01-06T03:31:23.0219142Z  │ │ [5/9] No configure step for 'ext_cpptoml'
2025-01-06T03:31:23.0598568Z  │ │ [6/9] No build step for 'ext_cpptoml'
2025-01-06T03:31:23.0975222Z  │ │ [7/9] No install step for 'ext_cpptoml'
2025-01-06T03:31:23.1352835Z  │ │ [8/9] No test step for 'ext_cpptoml'
2025-01-06T03:31:23.1888788Z  │ │ [9/9] Completed 'ext_cpptoml'
2025-01-06T03:31:23.2171891Z  │ │ -- Applying patch for minimal cmake version to cpptoml
2025-01-06T03:31:23.2375732Z  │ │ error: corrupt patch at line 7
2025-01-06T03:31:23.2408409Z  │ │ CMake Error at cmake/cpptoml/CMakeLists.txt:91 (message):
2025-01-06T03:31:23.2409491Z  │ │   CMake step [patch] for 'cpptoml-build' failed! Error code: 128!
2025-01-06T03:31:23.2413310Z  │ │ -- Configuring incomplete, errors occurred!
2025-01-06T03:31:23.2495837Z  │ │ %SRC_DIR%\build>if errorlevel 1 exit 1 
2025-01-06T03:31:23.2510970Z  │ │ × error Script failed with status 1
2025-01-06T03:31:23.2513140Z  │ │ × error Work directory: 'C:\bld\bld\rattler-build_ros-jazzy-iceoryx-posh_1736131220\work'

@traversaro
Copy link
Member

@traversaro: do you have any idea about this error in ros-jazzy-iceoryx-posh? I can't see any difference to the ros-humble version.

2025-01-06T03:31:21.7379884Z  │ │ [1/9] Creating directories for 'ext_cpptoml'
2025-01-06T03:31:22.8508358Z  │ │ [2/9] Performing download step (git clone) for 'ext_cpptoml'
2025-01-06T03:31:22.9460096Z  │ │ Cloning into 'src'...
2025-01-06T03:31:22.9463730Z  │ │ HEAD is now at fededad one-char typo
2025-01-06T03:31:22.9466682Z  │ │ Submodule 'deps/meta-cmake' (https://github.com/meta-toolkit/meta-cmake.git) registered for path 'deps/meta-cmake'
2025-01-06T03:31:22.9469410Z  │ │ Cloning into '%SRC_DIR%/build/dependencies/cpptoml/src/deps/meta-cmake'...
2025-01-06T03:31:22.9472292Z  │ │ Submodule path 'deps/meta-cmake': checked out 'db7ff976c430a6cb6cbd03ae691be04cfaac0a07'
2025-01-06T03:31:22.9474441Z  │ │ [3/9] Performing update step for 'ext_cpptoml'
2025-01-06T03:31:22.9841180Z  │ │ -- Already at requested tag: v0.1.1
2025-01-06T03:31:22.9842970Z  │ │ [4/9] No patch step for 'ext_cpptoml'
2025-01-06T03:31:23.0219142Z  │ │ [5/9] No configure step for 'ext_cpptoml'
2025-01-06T03:31:23.0598568Z  │ │ [6/9] No build step for 'ext_cpptoml'
2025-01-06T03:31:23.0975222Z  │ │ [7/9] No install step for 'ext_cpptoml'
2025-01-06T03:31:23.1352835Z  │ │ [8/9] No test step for 'ext_cpptoml'
2025-01-06T03:31:23.1888788Z  │ │ [9/9] Completed 'ext_cpptoml'
2025-01-06T03:31:23.2171891Z  │ │ -- Applying patch for minimal cmake version to cpptoml
2025-01-06T03:31:23.2375732Z  │ │ error: corrupt patch at line 7
2025-01-06T03:31:23.2408409Z  │ │ CMake Error at cmake/cpptoml/CMakeLists.txt:91 (message):
2025-01-06T03:31:23.2409491Z  │ │   CMake step [patch] for 'cpptoml-build' failed! Error code: 128!
2025-01-06T03:31:23.2413310Z  │ │ -- Configuring incomplete, errors occurred!
2025-01-06T03:31:23.2495837Z  │ │ %SRC_DIR%\build>if errorlevel 1 exit 1 
2025-01-06T03:31:23.2510970Z  │ │ × error Script failed with status 1
2025-01-06T03:31:23.2513140Z  │ │ × error Work directory: 'C:\bld\bld\rattler-build_ros-jazzy-iceoryx-posh_1736131220\work'

No idea, sorry!

@traversaro: do you have any idea about this error in ros-jazzy-iceoryx-posh? I can't see any difference to the ros-humble version.

2025-01-06T03:31:21.7379884Z  │ │ [1/9] Creating directories for 'ext_cpptoml'
2025-01-06T03:31:22.8508358Z  │ │ [2/9] Performing download step (git clone) for 'ext_cpptoml'
2025-01-06T03:31:22.9460096Z  │ │ Cloning into 'src'...
2025-01-06T03:31:22.9463730Z  │ │ HEAD is now at fededad one-char typo
2025-01-06T03:31:22.9466682Z  │ │ Submodule 'deps/meta-cmake' (https://github.com/meta-toolkit/meta-cmake.git) registered for path 'deps/meta-cmake'
2025-01-06T03:31:22.9469410Z  │ │ Cloning into '%SRC_DIR%/build/dependencies/cpptoml/src/deps/meta-cmake'...
2025-01-06T03:31:22.9472292Z  │ │ Submodule path 'deps/meta-cmake': checked out 'db7ff976c430a6cb6cbd03ae691be04cfaac0a07'
2025-01-06T03:31:22.9474441Z  │ │ [3/9] Performing update step for 'ext_cpptoml'
2025-01-06T03:31:22.9841180Z  │ │ -- Already at requested tag: v0.1.1
2025-01-06T03:31:22.9842970Z  │ │ [4/9] No patch step for 'ext_cpptoml'
2025-01-06T03:31:23.0219142Z  │ │ [5/9] No configure step for 'ext_cpptoml'
2025-01-06T03:31:23.0598568Z  │ │ [6/9] No build step for 'ext_cpptoml'
2025-01-06T03:31:23.0975222Z  │ │ [7/9] No install step for 'ext_cpptoml'
2025-01-06T03:31:23.1352835Z  │ │ [8/9] No test step for 'ext_cpptoml'
2025-01-06T03:31:23.1888788Z  │ │ [9/9] Completed 'ext_cpptoml'
2025-01-06T03:31:23.2171891Z  │ │ -- Applying patch for minimal cmake version to cpptoml
2025-01-06T03:31:23.2375732Z  │ │ error: corrupt patch at line 7
2025-01-06T03:31:23.2408409Z  │ │ CMake Error at cmake/cpptoml/CMakeLists.txt:91 (message):
2025-01-06T03:31:23.2409491Z  │ │   CMake step [patch] for 'cpptoml-build' failed! Error code: 128!
2025-01-06T03:31:23.2413310Z  │ │ -- Configuring incomplete, errors occurred!
2025-01-06T03:31:23.2495837Z  │ │ %SRC_DIR%\build>if errorlevel 1 exit 1 
2025-01-06T03:31:23.2510970Z  │ │ × error Script failed with status 1
2025-01-06T03:31:23.2513140Z  │ │ × error Work directory: 'C:\bld\bld\rattler-build_ros-jazzy-iceoryx-posh_1736131220\work'

Sorry, I was a bit in isolation to try to finish the ros humble Windows local rebuild. I am sure about this, but it seems you found a solution?

@traversaro
Copy link
Member

@Tobias-Fischer can you give me write access? I have some fixes that I would like to push to the branch.

@Tobias-Fischer
Copy link
Contributor Author

@traversaro done :)

@Tobias-Fischer
Copy link
Contributor Author

Made you an admin on the RoboStack org as well

@traversaro
Copy link
Member

Made you an admin on the RoboStack org as well

Thanks!

@Tobias-Fischer
Copy link
Contributor Author

@traversaro - are you happy to take a look locally at some of the remaining issues? I don't have a Windows machine, unfortunately. It seems like the errors should be trivial to fix (e.g. the latest: uint -> unsigned int, but I fear there are more than one packages that need fixing based on https://github.com/search?q=repo%3Aros-perception%2Fimage_transport_plugins%20uint&type=code)

@traversaro
Copy link
Member

@traversaro - are you happy to take a look locally at some of the remaining issues? I don't have a Windows machine, unfortunately. It seems like the errors should be trivial to fix (e.g. the latest: uint -> unsigned int, but I fear there are more than one packages that need fixing based on https://github.com/search?q=repo%3Aros-perception%2Fimage_transport_plugins%20uint&type=code)

Yes, I left the build running yesterday and so now it should have reached the problematic builds.

@Tobias-Fischer
Copy link
Contributor Author

All green - hooray! Thanks @traversaro :). Let’s merge here and add some more packages in a later PR

@Tobias-Fischer Tobias-Fischer merged commit 9ceb040 into main Jan 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Availability of jazzy on Windows?
2 participants