Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more packages on Windows #16

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Enable more packages on Windows #16

merged 8 commits into from
Jan 21, 2025

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jan 10, 2025

Follow up of #15 for Windows.

Fix #12 (comment) .

@traversaro
Copy link
Member Author

Ok, I had to skip plotjuggler and gtsam as they were not building, but moveit and navigation are now building ok (locally).

@Tobias-Fischer
Copy link
Contributor

Side-remark: I think the snapshot should be a config parameter in the vinca.yaml, not a command line argument. What do you think?

@Tobias-Fischer
Copy link
Contributor

More annoyingly it doesn't seem to work properly ;)

@traversaro
Copy link
Member Author

Side-remark: I think the snapshot should be a config parameter in the vinca.yaml, not a command line argument. What do you think?

Ok!

@traversaro
Copy link
Member Author

Side-remark: I think the snapshot should be a config parameter in the vinca.yaml, not a command line argument. What do you think?

Ok!

Done in RoboStack/vinca#70 . The pixi's PR environment is already using RoboStack/vinca#70 .

@traversaro
Copy link
Member Author

This PR also fixes prefix-dev/pixi#2910, as done for ros-humble in RoboStack/ros-humble#244 .

@Tobias-Fischer
Copy link
Contributor

So I just realised: the issue with having a single pkg_additional_info.yaml is that the "default" build numbers vary between different platforms, and we are now rebuilding new packages for some platforms. Not sure what the best way forward is .. the easiest would be to have a separate section within each vinca.yaml that contains the build number bumps, but I am not sure how clean this is. Or we have to make sure to have the build_numbers in sync in the future. Note that this is a bigger problem for e.g. noetic where the build_numbers vary a lot more than here.

@traversaro
Copy link
Member Author

So I just realised: the issue with having a single pkg_additional_info.yaml is that the "default" build numbers vary between different platforms, and we are now rebuilding new packages for some platforms. Not sure what the best way forward is .. the easiest would be to have a separate section within each vinca.yaml that contains the build number bumps, but I am not sure how clean this is. Or we have to make sure to have the build_numbers in sync in the future. Note that this is a bigger problem for e.g. noetic where the build_numbers vary a lot more than here.

Yes, that is the reason why I used an high number for build number on humble, and add a comment as remainder for the next build number. My idea was to align the build numbers in the next rebuild.

@traversaro
Copy link
Member Author

The CI seems happy.

@Tobias-Fischer
Copy link
Contributor

Amazing work @traversaro thanks a lot!

@Tobias-Fischer Tobias-Fischer merged commit da20595 into main Jan 21, 2025
5 checks passed
@Tobias-Fischer Tobias-Fischer deleted the featureparitywin branch January 21, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Availability of jazzy on Windows?
2 participants