Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release version in staging tarballs #251

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

mwoehlke-kitware
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware commented Nov 9, 2023

Modify how we build tarballs to use the release version rather than the date for staging builds.


This change is Reviewable

@mwoehlke-kitware
Copy link
Contributor Author

Since download_release_candidate.py is sort-of pulling the nightly binaries ATM (n.b. RobotLocomotion/drake#20339 (comment); in particular, we are using nightlies for macOS), I think it's "safe" to go ahead and merge this even if updating download_release_candidate.py is WIP.

Modify how we build tarballs to use the release version rather than the
date for staging builds.
@mwoehlke-kitware
Copy link
Contributor Author

+@BetsyMcPhail for review, please

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mwoehlke-kitware)

@BetsyMcPhail BetsyMcPhail merged commit fe48dec into main Nov 14, 2023
@BetsyMcPhail BetsyMcPhail deleted the version-staging-packages branch November 14, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants