Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update to macOS ventura #275

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

svenevs
Copy link
Contributor

@svenevs svenevs commented Nov 9, 2023

Relates: RobotLocomotion/drake#20339


This change is Reviewable

Copy link
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@BetsyMcPhail for review please. CI is happy which I'm pretty sure means we're good to go!

CC @jwnimmer-tri fyi

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)


.github/workflows/ci.yml line 70 at r1 (raw file):

          pip3.11 --version
      - name: setup
        run: ./scripts/continuous_integration/github_actions/macos_ventura/setup

FYI the only possible improvement here would be maybe we just make this a macos folder? It doesn't seem like we run two macOS distros here, and even if we did it's unlikely to differ? Doesn't make a huge difference to me.

Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, platform LGTM from [betsymcphail] (waiting on @svenevs)


.github/workflows/ci.yml line 70 at r1 (raw file):

Previously, svenevs (Stephen McDowell) wrote…

FYI the only possible improvement here would be maybe we just make this a macos folder? It doesn't seem like we run two macOS distros here, and even if we did it's unlikely to differ? Doesn't make a huge difference to me.

I'm happy to leave as is

@svenevs svenevs merged commit eb7e319 into main Nov 9, 2023
4 checks passed
@svenevs svenevs deleted the feat/upgrade-to-macos-ventura branch November 9, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants