Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/Updating Changes - NotebookBuilder Class #9

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

juliomachad0
Copy link
Member

Add coding (rocket objects and positions) to the add_surfaces_to_rocket method on the NotebookBuilder class (nb_builder.py)

…rocket method on the NotebookBuilder class (nb_builder.py)
@juliomachad0 juliomachad0 self-assigned this Jun 5, 2024
@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to buf/fix-open-rocket-wrangler-module June 5, 2024 04:29
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some minor issues with f-strings interpolation and fixed some other minor details in the nb_builder. It is working properly now.

Important: we need to merge this PR AFTER merging the #8 because I had to rebase this branch to get the new developments from #8.

image

PLEASE DON'T MERGE IT YET

@Gui-FernandesBR Gui-FernandesBR changed the base branch from buf/fix-open-rocket-wrangler-module to master June 5, 2024 15:19
@Gui-FernandesBR Gui-FernandesBR merged commit 32d5d24 into master Jun 5, 2024
1 check failed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/finding-fixing-errors branch June 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants