Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit readthedocs config file #278

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Add explicit readthedocs config file #278

merged 3 commits into from
Dec 21, 2023

Conversation

haiiliin
Copy link
Contributor

@haiiliin haiiliin commented Dec 19, 2023

ReadTheDocs has required an explicit configuration file since a few months ago, see https://docs.readthedocs.io/en/stable/config-file/, and the latest builds failed because of this. this pull request introduces the configuration file from the log history of the last successful build.

@haiiliin
Copy link
Contributor Author

Can anyone open the ReadTheDocs pull request builds and re-sync the webhook integration to decide whether the configuration is valid?

@lyskov
Copy link
Member

lyskov commented Dec 20, 2023

Thank you for putting this together @haiiliin ! Let me check if i can make this works...

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lyskov
Copy link
Member

lyskov commented Dec 20, 2023

OK, i resync the web-hooks and enable build-for-pull-requests so it now works. However the latest build failed due to error in config file. @haiiliin would you be so kind to troubleshoot this? Thanks,

@haiiliin
Copy link
Contributor Author

Works fine now

@lyskov
Copy link
Member

lyskov commented Dec 21, 2023

Awesome, - thank you @haiiliin !

@lyskov lyskov merged commit e1b80db into RosettaCommons:master Dec 21, 2023
12 checks passed
@haiiliin haiiliin deleted the readthedocs-config branch December 21, 2023 04:44
ldedier-gpfw pushed a commit to G-P-S/binder that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants