Building PHENIX interface - add missing imports #172
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the PHENIX interface does not work. Missing imports are thus added.
Put extra includes into #ifdef blocks
|
I'm guessing those headers disappeared because of the unused-header removal code. To avoid that happening in the future, I added a commit which wraps them in the same #ifdef used for the rest of the code. That should hopefully avoid them getting stripped out if we ever re-run the header code again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are errors while building the PHENIX interface. I added the missing imports. These are not sorted according to "Project headers", "Utility headers" etc.