Add debug printing for inline residue selector parsing logic. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some discussion that the inline logic for ResidueSelectors doesn't always do the same thing as the separate AND/OR/NOT selectors do. This PR adds a rudimentary nested residue selector printing facility, and enables it with debug output on the core.select.residue_selector.util tracer when parsing inline logic. It's primarily for debug purposes, and may or may not be useful in practice.
|
I don't know that they don't work in the same way, but that I can't get them to work at all. I know, it's unexplainable, and I don't have evidence in hand. But when I use explicit logic selectors I get the functionality I need... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some discussion (by e.g. @nannemdp) that the inline logic for ResidueSelectors doesn't always do the same thing as the separate AND/OR/NOT selectors do. This PR adds a rudimentary nested residue selector printing facility, and enables it with debug output on the core.select.residue_selector.util tracer when parsing inline logic.
It's primarily for debug purposes, and may or may not be useful in practice. (I didn't see any evidence of mis-parsing in the example under question.)