Fix fingerprint method

#fingerprint method memoizes its result, and it should not b/c it takes arguments.
SAML-Toolkits · Jan 13, 2025 · c70e911 · c70e911
1 parent 130b829
commit c70e911
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/onelogin/ruby-saml/idp_metadata_parser.rb b/lib/onelogin/ruby-saml/idp_metadata_parser.rb
@@ -384,14 +384,12 @@ def certificates
         # @return [String|nil] the fingerpint of the X509Certificate if it exists
         #
         def fingerprint(certificate, fingerprint_algorithm = XMLSecurity::Document::SHA1)
-          @fingerprint ||= begin
-            return unless certificate
+          return unless certificate
 
-            cert = OpenSSL::X509::Certificate.new(Base64.decode64(certificate))
+          cert = OpenSSL::X509::Certificate.new(Base64.decode64(certificate))
 
-            fingerprint_alg = XMLSecurity::BaseDocument.new.algorithm(fingerprint_algorithm).new
-            fingerprint_alg.hexdigest(cert.to_der).upcase.scan(/../).join(":")
-          end
+          fingerprint_alg = XMLSecurity::BaseDocument.new.algorithm(fingerprint_algorithm).new
+          fingerprint_alg.hexdigest(cert.to_der).upcase.scan(/../).join(":")
         end
 
         # @return [Array] the names of all SAML attributes if any exist