Revert change to fix spec

SAML-Toolkits · Jan 11, 2025 · cc50518 · cc50518
1 parent a21f37b
commit cc50518
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/lib/ruby_saml/slo_logoutrequest.rb b/lib/ruby_saml/slo_logoutrequest.rb
@@ -135,17 +135,17 @@ def issuer
     # @return [Time|nil] Gets the NotOnOrAfter Attribute value if exists.
     #
     def not_on_or_after
-      return @not_on_or_after if defined?(@not_on_or_after)
-
-      node = REXML::XPath.first(
-        document,
-        "/p:LogoutRequest",
-        { "p" => PROTOCOL }
-      )
+      @not_on_or_after ||= begin
+        node = REXML::XPath.first(
+          document,
+          "/p:LogoutRequest",
+          { "p" => PROTOCOL }
+        )
 
-      @not_on_or_after = if (value = node&.attributes&.[]("NotOnOrAfter"))
-                           Time.parse(value)
-                         end
+        if (value = node&.attributes&.[]("NotOnOrAfter"))
+          Time.parse(value)
+        end
+      end
     end
 
     # @return [Array] Gets the SessionIndex if exists (Supported multiple values). Empty Array if none found