v2.0: Merge latest master into v2.0 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch errant bullet point without space in Changelog.md
…_nameid Add support on LogoutRequest with Encrypted NameID
Adding sponsor button
Add sp_cert_multi to facilitate SP cert/key rotation
johnnyshields
force-pushed
the
update-v2.x-20240708
branch
from
bdd79f0 to
ec20f55
Compare
|
@pitbulk this is ready for your review now. |
pitbulk
reviewed
Jul 8, 2024
lib/onelogin/ruby-saml/version.rb
Outdated
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| module OneLogin | |||
| module RubySaml | |||
| VERSION = '1.15.0' | |||
| VERSION = '1.16.0' | |||
There was a problem hiding this comment.
@johnnyshields I'm more inclined to move to a 2.X version now that we have dropped support for old Ruby versions.
That way we can use 1.16 and 1.X for security bugfixes and key features we want to add to the old branch.
We should also update the changelog properly.
There was a problem hiding this comment.
Done! Changed to 2.0.0
|
I only have the concern of the ruby-saml version, the rest seems good to be merged. Do you want to fix this at this PR or later? We should also, after the PR 685, apply somehow adapted versions of: |
johnnyshields
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR catches up v2.x branch with the latest master code.
This PR also drops support for Ruby 2.6, 2.7 and JRuby 9.3 all of which are now both EOL. (Even Ruby 3.0 is EOL, but we can support it for now.)