Make IdpMetadataParser#get_idp_metadata public #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use-case for being able to cache the intermediate fetch of
metadata in case of temporary failures, so rather than:
I'd like to
There's a fair amount of logic in the
get_idp_metadata
method that I'drather not need to re-implement. Right now I have this implemented with
parser.send(:get_idp_metadata, url, true)
which is obviously not greatif the internals of this class change in the future. Can we move this
method to the public API?