[READY] v2.0 - Consistently format cert/private key PEMs #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
force-pushed
the
pem-formatter
branch
from
6184ae4 to
d985988
Compare
12 tasks
johnnyshields
commented
Jul 11, 2024
|
|
||
| module RubySaml | ||
|
|
||
| # SAML2 Auxiliary class | ||
| # | ||
| class Utils | ||
| module Utils | ||
| extend self |
There was a problem hiding this comment.
Converted Utils to module. It was a singleton previously so this shouldn't break anything.
johnnyshields
commented
Jul 11, 2024
| settings.certificate = ruby_saml_cert_text | ||
| wrong_private_key = ruby_saml_key_text.sub!('A', 'B') | ||
| wrong_private_key = ruby_saml_key_text.sub!('Z', 'X') |
There was a problem hiding this comment.
This spec was kind of silly before, previously ruby_saml_key_text.sub!('A', 'B') was gsubbing -----RSA PRIVATE KEY----- to RSB, and not actually affecting the pkey body. I've improved it so we are now testing for corrupted key body.
My new logic will actually tolerate the case of ----BEGIN RSB PRIVATE KEY----- and just normalize it to -----BEGIN PRIVATE KEY-----, so the old test actually passes now.
johnnyshields
force-pushed
the
pem-formatter
branch
2 times, most recently
from
2f319bf to
93b063a
Compare
johnnyshields
changed the title
johnnyshields
force-pushed
the
pem-formatter
branch
7 times, most recently
from
3694dea to
822da55
Compare
johnnyshields
changed the title
…y PEM values, including the `RubySaml::Util#format_cert` and `#format_private_key` methods. Introduces new `RubySaml::PemFormatter` module.
johnnyshields
force-pushed
the
pem-formatter
branch
from
822da55 to
113f39a
Compare
|
@pitbulk this is ready for your review and merge. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636
I've tried to make this as compatible as possible with the legacy behavior while still handling the case stripping out text before/after the PEM string.
All existing test cases behave as before (* see comment below--there's one case that needed a minor alteration as the case itself was written incorrectly.)