Update for frozen string compatibility #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HParker
force-pushed
the
compatibility-with-frozen-strings
branch
2 times, most recently
from
44b14ce to
4d7d16e
Compare
This marks mutable strings to allow tests to pass with
RUBYOPT="--enable-frozen-string-literal"
enabled.
This will be the default in future Ruby versions, so being compatible now is ideal.
HParker
force-pushed
the
compatibility-with-frozen-strings
branch
from
4d7d16e to
8350125
Compare
|
This is not needed. v2.x already takes care of this with magic comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks mutable strings to allow tests to pass with
enabled.
This will be the default in future Ruby versions, so being compatible now is ideal.