Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from main #23

Open
wants to merge 17 commits into
base: solution
Choose a base branch
from
Open

merge from main #23

wants to merge 17 commits into from

Conversation

vijayrajput
Copy link

No description provided.

georgbischoff and others added 17 commits November 8, 2022 15:29
Removed Contributing section as this is a sample repository for a tutorial.
Removed the default repo text
* Updated dependencies

* Added workspace for wdi5 to package.json

* soluton branch

* Co-authored-by: Bischoff, Georg <[email protected]>

* readme file+ update

* typo fix

* feat: update solution to new wdi5 installation

* feat: deployable app

* refactor: move files out of bookshop

* feat: update dependencies

* feat: make build succeed in ci

* feat: deployable app

* feat: deployable_app

* WIP: buildable service

* wip: sqlite in place

- replace hana deployment

* wip: deployable app

- remove csn.json while deployment and use .cds files

Co-authored-by: Volker Buzek <[email protected]>

* refactor: cleanup unnecessary files

* feat: add initial data to deployment

* fix: use stable wdi5 version

* chore: update lock

* fix: make conf CI/CD ready

* fix: use chromedriver 105 for CI/CD service

* chore: use latest dependencies for wdi5

* chore: remove vscode settings

* refactor deployable app

- use always newest ui5 version
- use always latest chromedriver version

* refactor: remove typo from dependency version

* feat: make branch ready for main

* feat: remove dependencies

* chore: update package-lock

Co-authored-by: Georg Bischoff <[email protected]>
Co-authored-by: I504692 <[email protected]>
Co-authored-by: georgbischoff <[email protected]>
Co-authored-by: Volker Buzek <[email protected]>
@cla-assistant
Copy link

cla-assistant bot commented Aug 1, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ btbernard
✅ georgbischoff
✅ priyankagayen
✅ Siolto
✅ ajinkyapatil8190
❌ vijayrajput
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Aug 1, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ Siolto
✅ priyankagayen
✅ georgbischoff
✅ ajinkyapatil8190
✅ btbernard
❌ vijayrajput
You have signed the CLA already but the status is still pending? Let us recheck it.

"deploy": "cf deploy gen/mta.tar -f"
},
"engines": {
"node": "^16"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"node": "^16"
"node": "^18"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in the main. Maybe you need to update your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants