Skip to content

Commit

Permalink
docs: ng19 typedoc fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
droshev committed Dec 30, 2024
1 parent d5ed28f commit 9bb9e08
Show file tree
Hide file tree
Showing 28 changed files with 1,580 additions and 885 deletions.
1 change: 0 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@
"types": "prefer-import"
}
],
"@typescript-eslint/type-annotation-spacing": "error",
"@typescript-eslint/unified-signatures": "error",
"arrow-body-style": "error",
"arrow-parens": ["off", "always"],
Expand Down
4 changes: 2 additions & 2 deletions libs/cdk/utils/typecheck.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Observable } from 'rxjs';
/**
* Helper function check whether passed data is a JS object (including function).
*/
// eslint-disable-next-line @typescript-eslint/ban-types
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
export function isJsObject(obj: any): obj is object | Function {
return obj !== null && (typeof obj === 'function' || typeof obj === 'object');
}
Expand Down Expand Up @@ -51,7 +51,7 @@ export function isFunction(obj: any): boolean {
}

/** @hidden */
// eslint-disable-next-line @typescript-eslint/ban-types
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
export function isType(obj: any): obj is Function {
return isFunction(obj);
}
Expand Down
8 changes: 4 additions & 4 deletions libs/core/avatar-group/avatar-group.component.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '@sap-ui/common-css/dist/sass/_common-mixins.scss';
@import 'fundamental-styles/dist/avatar-group.css';
@use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap;
@use 'fundamental-styles/dist/avatar-group.css';

@mixin fd-avatar-element() {
> .fd-popover__control > fd-popover-control > .fd-avatar {
Expand All @@ -19,13 +19,13 @@ fd-avatar-group {
height: 100%;
}
@include fd-avatar-element() {
@include sap-set-margin-begin(var(--fdAvatarGroupItemsGap));
@include sap.sap-set-margin-begin(var(--fdAvatarGroupItemsGap));
}
}

> fd-popover:first-child {
@include fd-avatar-element() {
@include sap-set-margin-x-equal(0);
@include sap.sap-set-margin-x-equal(0);
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions libs/core/link/link.component.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '@sap-ui/common-css/dist/sass/_common-mixins.scss';
@import 'fundamental-styles/dist/link.css';
@use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap;
@use 'fundamental-styles/dist/link.css';

$block: fd-link;

Expand All @@ -13,11 +13,11 @@ $block: fd-link;
justify-content: center;
align-items: center;
&:first-child {
@include sap-set-margin-end(var(--fdLink_Icon_Spacing, 0));
@include sap.sap-set-margin-end(var(--fdLink_Icon_Spacing, 0));
}

&:last-child {
@include sap-set-margin-begin(var(--fdLink_Icon_Spacing, 0));
@include sap.sap-set-margin-begin(var(--fdLink_Icon_Spacing, 0));
}
}
}
4 changes: 2 additions & 2 deletions libs/core/message-toast/message-toast.component.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import '@angular/cdk/overlay-prebuilt';
@import 'fundamental-styles/dist/message-toast.css';
@use '@angular/cdk/overlay-prebuilt.css';
@use 'fundamental-styles/dist/message-toast.css';

.fn-toast-overlay-container {
.cdk-overlay-pane {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '@sap-ui/common-css/dist/sass/_common-mixins.scss';
@use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap;

fd-multi-combobox-select-all-toggler {
display: block;
Expand All @@ -8,7 +8,7 @@ fd-multi-combobox-select-all-toggler {
top: 0;
z-index: 1;

@include sap-fiori-focus();
@include sap.sap-fiori-focus();

.fd-toolbar {
padding-left: 0;
Expand All @@ -25,7 +25,7 @@ fd-multi-combobox-select-all-toggler {
pointer-events: none;

.fd-checkbox__checkmark {
@include sap-set-margin-end(0.5rem);
@include sap.sap-set-margin-end(0.5rem);
}

.fd-checkbox__text {
Expand Down
4 changes: 2 additions & 2 deletions libs/core/popover/popover-body/popover-body.component.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import 'fundamental-styles/dist/popover.css';
@import '@angular/cdk/overlay-prebuilt';
@use 'fundamental-styles/dist/popover.css';
@use '@angular/cdk/overlay-prebuilt.css';

$block: fd-popover;
$fd-popover-border-radius: var(--fdPopover_Border_Radius);
Expand Down
3 changes: 2 additions & 1 deletion libs/core/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"compile-typedoc": {
"executor": "@fundamental-ngx/nx-plugin:compile-typedoc",
"options": {
"outputPath": "libs/docs/typedoc/core"
"outputPath": "libs/docs/typedoc/core",
"tsConfig": "libs/core/tsconfig.typedoc.json"
},
"outputs": ["{options.outputPath}"]
},
Expand Down
Loading

0 comments on commit 9bb9e08

Please sign in to comment.