Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): enable segmented button #12808

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Dec 3, 2024

fixes #12675

fix enable segmented button
delete e2e as the unit tests cover the testing enough

@droshev droshev requested a review from a team December 3, 2024 18:19
@droshev droshev self-assigned this Dec 3, 2024
@droshev droshev added this to the Sprint 141 - December 2024 milestone Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit d690ce8
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/677bfd9f72367200080fa720
😎 Deploy Preview https://deploy-preview-12808--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 3, 2024

Visit the preview URL for this PR (updated for commit d690ce8):

https://fundamental-ngx-gh--pr12808-fix-segmented-button-hcq49jdu.web.app

(expires Thu, 09 Jan 2025 16:03:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does allow the segmented button to be focused again, however I can no longer use the arrow keys to change the selected segment. Still working for the other examples, I'm just seeing this problem on the newly modified example

@InnaAtanasova
Copy link
Contributor

This does allow the segmented button to be focused again, however I can no longer use the arrow keys to change the selected segment. Still working for the other examples, I'm just seeing this problem on the newly modified example

I can confirm the same thing. The arrow keys are not working. Also, I would suggest an improvement for the example. Add a button that programatically disables and enables the Segmented button. Additionally, explain in a 2-3 short sentences what this example is doing. Right now, with the short timeout, for people that don't have an idea what the issue is, it's not very clear why we have this example.

@droshev
Copy link
Contributor Author

droshev commented Dec 5, 2024

so, I would suggest an improvement for the example. Add a button that programatically disables and enables the Segmented button. Additionally, e

fixed!

@droshev droshev force-pushed the fix/segmented-button-enable branch from 2ad5fe2 to fa30ef7 Compare December 7, 2024 20:02
@droshev droshev force-pushed the fix/segmented-button-enable branch from 5c11b11 to 0963dc7 Compare December 19, 2024 19:28
@mikerodonnell89
Copy link
Member

so, I would suggest an improvement for the example. Add a button that programatically disables and enables the Segmented button. Additionally, e

fixed!

I am not seeing an update regarding Inna's documentation suggestions

Also, while I am seeing the arrow key focus problem is fixed, I can no longer use enter/space to change the selection on this example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmented-button Accessibility when switching between disabled/enabled
3 participants