Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove query parameters when applying akamai token #270

Merged

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Oct 24, 2023

Pull request

Description

This PR fix the way AkamaiTokenProvider append token to the base Uri.

Changes made

  • Use like in SRGLetterbox a UrlSanitizer to extract encoded query parameters and keys.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Oct 24, 2023 that may be closed by this pull request
2 tasks
@StaehliJ StaehliJ changed the title Don't remove query parameters when applying token Don't remove query parameters when applying akamai token Oct 24, 2023
@StaehliJ StaehliJ merged commit 17050e9 into main Oct 24, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 269-fix-akamai-token-generation-for-url-with-parameters branch October 24, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Akamai token generation for url with parameters
1 participant